-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve docs: A11y: Link vs text contrast does not meet WCAG guidelines #460
Comments
@mobot11 3:1 contrast ratio is reserved for exceptionally large text. For the majority of the text, we actually need to hit 4.5:1. |
@mobot11 is this specifically to fundamental-react or it comes from fiori-fundamentals? |
@droshev Looks like these are the defaults from fiori-fundamentals. I can open an issue on that repo as well. |
@bcullman I believe specifically for the contrast between the link color and the text color we are only required to provide a 3:1 ratio according to https://webaim.org/articles/contrast/#only. |
The short version: I don't see any problems. I reviewed the Fundamental Link (https://sap.github.io/fundamental/components/link.html) page and had 2 quick findings:
|
Description
WCAG requires "A 3:1 contrast between the link text color and the surrounding non-link text color." This might turn into an issue with fiori-fundamentals. Can check the allowable contrast levels here: https://webaim.org/resources/linkcontrastchecker/
Versions
fundamental-react:
fiori-fundamentals:
NOTE: Where applicable, please include uncropped screen captures.
DISCLAIMER:
After triaging an issue, the fundamental-react team will see if it can be reproduced or confirmed. If more information is needed, the fundamental-react team will contact the author. Any issues awaiting responses from the author for more than 7 days will be closed. The author can re-open the issue at a later time if they can present the requested information.
The text was updated successfully, but these errors were encountered: