Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs: A11y: Link vs text contrast does not meet WCAG guidelines #460

Closed
mobot11 opened this issue Mar 5, 2019 · 6 comments
Closed
Labels
A11y Accessiblity contribution welcome The fix or enhancement is approved and you are invited to contribute to it

Comments

@mobot11
Copy link
Contributor

mobot11 commented Mar 5, 2019

Description

WCAG requires "A 3:1 contrast between the link text color and the surrounding non-link text color." This might turn into an issue with fiori-fundamentals. Can check the allowable contrast levels here: https://webaim.org/resources/linkcontrastchecker/

Versions

fundamental-react:
fiori-fundamentals:


NOTE: Where applicable, please include uncropped screen captures.

DISCLAIMER:
After triaging an issue, the fundamental-react team will see if it can be reproduced or confirmed. If more information is needed, the fundamental-react team will contact the author. Any issues awaiting responses from the author for more than 7 days will be closed. The author can re-open the issue at a later time if they can present the requested information.

@mobot11 mobot11 added contribution welcome The fix or enhancement is approved and you are invited to contribute to it A11y Accessiblity labels Mar 5, 2019
@bcullman
Copy link
Contributor

bcullman commented Mar 6, 2019

@mobot11 3:1 contrast ratio is reserved for exceptionally large text. For the majority of the text, we actually need to hit 4.5:1.

@droshev
Copy link
Contributor

droshev commented Mar 6, 2019

@mobot11 is this specifically to fundamental-react or it comes from fiori-fundamentals?

@mobot11
Copy link
Contributor Author

mobot11 commented Mar 6, 2019

@droshev Looks like these are the defaults from fiori-fundamentals. I can open an issue on that repo as well.

@jbadan
Copy link
Contributor

jbadan commented Mar 6, 2019

@mobot11 @droshev A couple of the buttons have this same problem, specifically medium (orange) and light buttons.

Edit: The light buttons only fail with our code sample background which will be fixed by #461

@mobot11
Copy link
Contributor Author

mobot11 commented Mar 6, 2019

@bcullman I believe specifically for the contrast between the link color and the text color we are only required to provide a 3:1 ratio according to https://webaim.org/articles/contrast/#only.

@gszalay
Copy link

gszalay commented Apr 9, 2019

The short version: I don't see any problems.

I reviewed the Fundamental Link (https://sap.github.io/fundamental/components/link.html) page and had 2 quick findings:

  1. The colors in Fundamental do not match the colors in the Fiori 3 Master Sketch file. I would therefore assume the Fundamental colors are not final and will change.
  2. This section of WebAim (https://webaim.org/articles/contrast/#only) applies to links when no other indicator (such as underline) is used. So, the 3:1 rule is not applicable if there is an underline (which is displayed in Fundamental)

@jbadan jbadan closed this as completed Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y Accessiblity contribution welcome The fix or enhancement is approved and you are invited to contribute to it
Projects
None yet
Development

No branches or pull requests

5 participants