Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom IDP provider wrong check for login method #654

Closed
pekura opened this issue Jul 12, 2019 · 0 comments · Fixed by #665
Closed

Custom IDP provider wrong check for login method #654

pekura opened this issue Jul 12, 2019 · 0 comments · Fixed by #665
Assignees
Labels
bug Something isn't working
Milestone

Comments

@pekura
Copy link
Contributor

pekura commented Jul 12, 2019

A custom IDP provider must fulfill certain condition, for example it must implement the 'login' function. The check for existence of this function is wrong though. If you specify a custom IDP like this:

class CustomIDPProvider {
      login() {
        // do stuff
      }
}

you get following error: "Error: login function does not exist in custom IDP Provider custom".

You need to add 'login' property to the CustomIDPProvider addtitionally, like this:

CustomIDPProvider.login = function() {};

This should not be necessary. The login function of the class is used effectively.

@pekura pekura added this to the Backlog milestone Jul 12, 2019
@pekura pekura added the bug Something isn't working label Jul 12, 2019
@hardl hardl modified the milestones: Backlog, Sprint_2 Jul 15, 2019
@maxmarkus maxmarkus self-assigned this Jul 18, 2019
@jesusreal jesusreal modified the milestones: Sprint_2, Sprint 3 Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants