Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamicPageHeader expanded automatically on scroll on mobile devices #4129

Open
Kalo2412 opened this issue Sep 24, 2024 · 8 comments
Open

DynamicPageHeader expanded automatically on scroll on mobile devices #4129

Kalo2412 opened this issue Sep 24, 2024 · 8 comments
Assignees

Comments

@Kalo2412
Copy link

Kalo2412 commented Sep 24, 2024

OpenUI5 version: 1.117.0

Browser/version (+device/version): 'Mozilla/5.0 (iPhone; CPU iPhone OS 16_6 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.6 Mobile/15E148 Safari/604.1'

Any other tested browsers/devices(OK/FAIL):

URL (minimal example if possible): https://sapui5.hana.ondemand.com/#/entity/sap.f.DynamicPage/sample/sap.f.sample.DynamicPageWithStickySubheader/code

User/password (if required and possible - do not post any confidential information here):

Steps to reproduce the problem:

  1. Set the DynamicPage attribute "headerExpanded" to false

What is the expected result? The header should not be expanded automatically on scroll

What happens instead? The header is internally expanded automatically on scroll

Any other information? (attach screenshot if possible)

https://teamschedule-my.sharepoint.com/:v:/g/personal/mihael_kirov_teamschedule_digital/Eac25tkkwzpPlanvi3NGuoABZGiRSpzccp9959XwNyzDxw?nav=eyJyZWZlcnJhbEluZm8iOnsicmVmZXJyYWxBcHAiOiJPbmVEcml2ZUZvckJ1c2luZXNzIiwicmVmZXJyYWxBcHBQbGF0Zm9ybSI6IldlYiIsInJlZmVycmFsTW9kZSI6InZpZXciLCJyZWZlcnJhbFZpZXciOiJNeUZpbGVzTGlua0NvcHkifX0&e=aprmvL

@MapTo0
Copy link
Member

MapTo0 commented Sep 25, 2024

Hello @Kalo2412

headerExpanded sets the initial state of the header
preserveHeaderStateOnScroll defines if the state should be preserved while the user is scrolling.

I guess you need a combination of these two properties.

Best Regards!
Martin
UI5 Development Support

@Kalo2412
Copy link
Author

@MapTo0 Thank you very much for the answer, unfortunately in landscape mode this property does not make any difference even if set to true (preserveHeaderStateOnScroll). Can you check it? We need this to be always true.

@Kalo2412
Copy link
Author

@MapTo0 ?

@MapTo0
Copy link
Member

MapTo0 commented Sep 27, 2024

Hey @Kalo2412

I could not reproduce the issue on my side.
Could you please recheck this bin and provide steps to reproduce and expected behaviour? https://jsbin.com/dufakuhofi/4/edit?html,console

Best Regards,
Martin

@MapTo0
Copy link
Member

MapTo0 commented Sep 27, 2024

Hello @Kalo2412 ,
Thank you for sharing this finding. I've created an internal incident DINC0281679. The status of the issue will be updated here in GitHub.

Regards,
Martin

@jdichev
Copy link
Contributor

jdichev commented Nov 1, 2024

Hello @Kalo2412,

What you describe is the expected behavior. It is documented in the property's documentation that it only serves to initiate the control in a certain state but user interaction can affect the state.

If you seek the header to never expand once initialized in collapsed state you could use the preserveHeaderStateOnScroll property.

Best regards,
Jordan

@jdichev jdichev closed this as completed Nov 1, 2024
@Kalo2412
Copy link
Author

Kalo2412 commented Nov 4, 2024

@jdichev As I mentioned preserveHeaderStateOnScroll is not taken into account even if set to true it is still opened on scroll please see the video

@jdichev jdichev reopened this Nov 7, 2024
@jdichev jdichev self-assigned this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants