Use type safe asserts for (unit) testing

[geryxyz]

Consider the following code chunk.

def test_extract_references_vuln_id():
    commit = Commit(
        commit_id="test_commit",
        repository="test_repository",
        cve_refs=["test_advisory_record", "another_advisory_record"],
    )
    advisory_record = AdvisoryRecord(vulnerability_id="test_advisory_record")
    result = extract_references_vuln_id(commit, advisory_record)
    assert result

My opinion is that this is a bad and discouraged practice, since the final assert disguise any implicit type conversions. For example in the case when the SUT is changed like in the case of #190

I suggest preferring the type safe version for every assert statement during testing (even in the case of boolean assertion). For example, like below.

def test_extract_references_vuln_id():
    commit = Commit(
        commit_id="test_commit",
        repository="test_repository",
        cve_refs=[
            "test_advisory_record",
            "another_advisory_record",
            "yet_another_advisory_record",
        ],
    )
    advisory_record = AdvisoryRecord(vulnerability_id="test_advisory_record")
    result = extract_references_vuln_id(commit, advisory_record)
    assert result is True

[copernico]

Agreed!

[copernico]

@geryxyz can we close this issue, based on your work in #194?
If not, what remains to be done?
Thanks!

[geryxyz]

I think yes, at least I am unaware of any non-safe asserts in the code. For the record, they are quite tricky and time consuming to locate since in most of the case the test pass because the implicit conversions kick in. I.e. the problem is with the semantic of the test case, not the implementation.

[copernico]

See #208