Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle partial success of a batch request #64

Open
DimonLuk opened this issue Oct 9, 2019 · 3 comments
Open

Handle partial success of a batch request #64

DimonLuk opened this issue Oct 9, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@DimonLuk
Copy link

DimonLuk commented Oct 9, 2019

Hi everyone. I work on a big project that uses pyodata library for making batch requests and some times only one or more sub requests have failed and others are successful but the library throws an error and the problem here that I can't handle successful responses but I really need to. For my own use I've created a tricky solution for this but I'd like to know if there's a proper way to deal with such situations? Can this situation be handled with the current version of the library? If answers for the above questions are no I can prepare PR from what I have in production ( which will give user a choice between old and new behaviour) of course if such functionality is something that the library can adopt

@filak-sap
Copy link
Contributor

@mnezerka PTAL

@filak-sap filak-sap added the enhancement New feature or request label Oct 21, 2019
@filak-sap filak-sap changed the title Handle partial success Handle partial success of a batch request Oct 21, 2019
@DimonLuk
Copy link
Author

Any progress?

@filak-sap
Copy link
Contributor

@DimonLuk I am sorry for not following up on this issue earlier. Currently we are busy with adding support for OData V4.

I had a quick look at our batch implementation and I don't think you can handle partial success with the current code base. However, it should not be that hard to add support for it. We usually struggle to find the expected behaviour and the best way how to enable users to consume our API. Feel free to open a PR, because we cannot get back to this issue soon. Please, before you invest too much time, send us some usage examples of your proposed chages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants