-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING] Bundling: Enforce usage of sap.ui.predefine instead function wrappers #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flovogt
changed the title
[FEATURE] Bundling: Remove option 'usePredefineCalls'
[FEATURE] Bundling: Use sap.ui.predefine calls for bundling
May 17, 2024
flovogt
changed the title
[FEATURE] Bundling: Use sap.ui.predefine calls for bundling
[FEATURE] Bundling: Use sap.ui.predefine calls
May 17, 2024
flovogt
changed the title
[FEATURE] Bundling: Use sap.ui.predefine calls
[FEATURE] Bundling: Use sap.ui.predefine
May 17, 2024
flovogt
force-pushed
the
remove-usePredefineCalls-option
branch
2 times, most recently
from
May 21, 2024 13:07
919474e
to
96a3932
Compare
This was referenced May 21, 2024
flovogt
changed the title
[FEATURE] Bundling: Use sap.ui.predefine
[FEATURE] Bundling: Enforce usage of sap.ui.predefine instead function wrappers
May 21, 2024
flovogt
force-pushed
the
remove-usePredefineCalls-option
branch
from
May 21, 2024 13:27
96a3932
to
b335c3b
Compare
flovogt
force-pushed
the
remove-usePredefineCalls-option
branch
from
May 21, 2024 13:28
b335c3b
to
7b88583
Compare
flovogt
changed the title
[FEATURE] Bundling: Enforce usage of sap.ui.predefine instead function wrappers
[BREAKING] Bundling: Enforce usage of sap.ui.predefine instead function wrappers
May 21, 2024
d3xter666
approved these changes
May 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
RandomByte
approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until UI5 Tooling v3, the bundle option "usePredefineCalls" defaults to "false" and has to be activated explicitly in a custom bundle configuration.
For default bundles, such as Component-preload or self-contained bundle (sap-ui-custom.js), there is no way to use the option apart from re-defining the whole bundle via custom bundle definition.
With UI5 Tooling v4 bundles are generated with the usage sap.ui.predefine calls instead of the former default function wrapper. This leads to smaller bundle sizes and less overhead at runtime.
As the option only affects the internal handling of bundling without affecting the actual users,
the option is removed completely, instead of just changing the default value of the option.
Documentation update covered in SAP/ui5-tooling#957.
JIRA: CPOUI5FOUNDATION-760
BREAKING CHANGE:
Created bundles use sap.ui.predefine instead function wrappers. For projects this is a compatible change. Only the produced bundle content changes.