Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] ComponentAnalyzer: Fully handle sap.ui5/routing #124

Merged
merged 3 commits into from
Jan 2, 2019
Merged

[FIX] ComponentAnalyzer: Fully handle sap.ui5/routing #124

merged 3 commits into from
Jan 2, 2019
+158 −60

Conversation

matz3
Copy link
Member

@matz3 matz3 commented Dec 21, 2018 •
edited
Loading

No description provided.

@matz3 matz3 added the bug Something isn't working label Dec 21, 2018
@matz3 matz3 force-pushed the component-analyzer-add-routerClass branch from ddc65b5 to 34d16ff Compare December 21, 2018 15:19
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 53.963% when pulling 34d16ff on component-analyzer-add-routerClass into 10383c1 on master.

@coveralls
Copy link

coveralls commented Dec 21, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.08%) to 53.822% when pulling 1fc431b on component-analyzer-add-routerClass into 10383c1 on master.

@matz3
Copy link
Member Author

matz3 commented Jan 2, 2019

Ready for review

@RandomByte
Copy link
Member

Please squash into one commit

@matz3 matz3 merged commit c59b5b1 into master Jan 2, 2019
@matz3 matz3 deleted the component-analyzer-add-routerClass branch January 2, 2019 12:19
@matz3 matz3 mentioned this pull request Jan 9, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomByte RandomByte RandomByte approved these changes

@codeworrior codeworrior Awaiting requested review from codeworrior

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matz3 @coveralls @RandomByte