Bundle builder now uses same regexp for copyrights as uglifier task #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomByte
previously requested changes
Jun 25, 2019
There was a problem hiding this comment.
Please prefix your commit message with [FIX] as documented here
codeworrior
force-pushed
the
fix-bundler-copyright-regexp
branch
from
5bd4406
to
d2e1f30
Compare
matz3
reviewed
Jun 26, 2019
| @@ -19,7 +19,7 @@ const {SectionType} = require("./BundleDefinition"); | |||
| const BundleWriter = require("./BundleWriter"); | |||
| const log = require("@ui5/logger").getLogger("lbt:bundle:Builder"); | |||
|
|
|||
| const copyrightCommentsPattern = /copyright|\(c\)|released under|license|\u00a9/i; | |||
There was a problem hiding this comment.
What about the AutoSplitter.js?
It also has a "copyrightCommentsPattern" with the shorter RegExp
matz3
approved these changes
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/SAP/ui5-builder/issues/257 .
Thank you for your contribution! 🙌
To get it merged faster, kindly review the checklist below:
Pull Request Checklist