[FEATURE] Properties File Escaping #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add processor which escapes non ASCII characters in resources.
Add task escapeNonAsciiCharacters which uses stringEscaper to escape non ascii characters. Made it generic using a pattern to re-use it for potential other files.
Add task "escapeNonAsciiCharacters" to ApplicationBuilder and LibraryBuilder. Add non-ascii characters to i18n test files.
Thodd
reviewed
Jul 18, 2019
Change name of constant and adjust its jsdoc for clarification.
matz3
previously requested changes
Jul 19, 2019
- Always escape chars - Read files in source-encoding
|
|
|
@tobiasso85: |
Fix expected outcome in test
#fixedit #unbreakable |
Adjust encoding parameter
Expose stringEscaper processor and escapeNonAsciiCharacters task via index.js to be able to consume it from server module.
Add default to formatter. Adjust tests.
RandomByte
reviewed
Jul 22, 2019
Rename stringEscaper to nonAsciiEscaper since it only escapes non ascii characters. Made encoding a required parameter for the task. Added static method to nonAsciiEscaper processor since node.js encoding does not support "ISO-8859-1" only knows it as "latin1" though.
renamed variable
Thodd
previously requested changes
Jul 23, 2019
Set default in formatters for encoding value. Add validation to formatters for encoding value.
Only apply encoding in AutoSplitter and Builder if encoding value is specified.
ui5.yml. It makes more sense to group it under configuration.
RandomByte
reviewed
Jul 24, 2019
Include prefix and option name in escapeNonAsciiCharacters task
RandomByte
requested changes
Jul 24, 2019
RandomByte
reviewed
Jul 24, 2019
test/expected/build/application.b/dest/manifest-bundle/i18n/i18n.properties
Outdated
Show resolved
Hide resolved
matz3
requested changes
Jul 24, 2019
matz3
previously requested changes
Jul 26, 2019
propertiesFileEncoding -> propertiesSourceFileEncoding
propertiesSourceFileEncoding -> propertiesFileSourceEncoding
RandomByte
requested changes
Jul 29, 2019
Separated default encoding tests
RandomByte
approved these changes
Jul 29, 2019
|
Fine for me. Please use "Squash and merge"! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add processor which escapes non ASCII characters in resources.
As per RFC 0007: SAP/ui5-tooling#168