Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] Align set of known file types with runtime #337

Merged
merged 1 commit into from
Sep 20, 2019

Conversation

codeworrior
Copy link
Member

UI5 runtime knows JavaScript file types controller, designtime, fragment, support and view.

TODO: support files should not be uglified (to keep the rules source code readable). It has to be decided whether this is realized by configuration or whether it should be hard coded in the task / processor or (library) type. Nevertheless, the tooling should know that type anyhow to be able to handle it correctly.

Fixes #336

UI5 runtime knows JavaScript file types controller, designtime,
fragment, support and view.

TODO: support files should not be uglified (to keep the rules source
code readable). It has to be decided whether this is realized by
configuration or whether it should be hard coded in the task / processor
or (library) type.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 86.618% when pulling 6a53ed1 on update-known-file-extensions into 327cca0 on master.

Copy link
Member

@matz3 matz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this actually a [FIX]?

@codeworrior
Copy link
Member Author

@matz3: I don't mind.

@matz3 matz3 merged commit 8b372f1 into master Sep 20, 2019
@matz3 matz3 deleted the update-known-file-extensions branch September 20, 2019 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug files for *.designtim.js or *.support.js get a name which doesn't match the runtime's expectation
4 participants