Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Tag bundles and ignore them in uglify task #535

Merged
merged 3 commits into from
Nov 2, 2020
Merged

Conversation

RandomByte
Copy link
Member

No description provided.

@RandomByte RandomByte requested a review from matz3 October 22, 2020 15:30
@RandomByte RandomByte marked this pull request as draft October 22, 2020 15:31
@RandomByte RandomByte marked this pull request as ready for review October 26, 2020 10:29
@@ -29,8 +32,11 @@ module.exports = function({workspace, dependencies, options: {projectName, bundl
},
resources
}).then((bundles) => {
bundles.forEach((bundle) => {
workspace.write(bundle);
return bundles.map((bundle) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't Promise.all missing here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@RandomByte RandomByte merged commit b487366 into master Nov 2, 2020
@RandomByte RandomByte deleted the tag-bundles branch November 2, 2020 15:06
RandomByte added a commit that referenced this pull request Nov 10, 2021
Seems like an oversight in #535.
The tag can already be used and should be documented in the API reference
RandomByte added a commit that referenced this pull request Nov 10, 2021
Seems like an oversight in #535.
The tag can already be used and should be documented in the API reference
RandomByte added a commit that referenced this pull request Nov 16, 2021
Seems like an oversight in #535.
The tag can already be used and should be documented in the API reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants