[FIX] Handle graceful termination of workerpool for parallel builds #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomByte
reviewed
Nov 8, 2023
There was a problem hiding this comment.
Just to get a clear picture: Can the issue being fixed here occur in regular UI5 CLI builds? Or only in scenarios like SAP/ui5-tooling#894 where multiple minify tasks run in parallel?
d3xter666
force-pushed
the
fix-workerpool-termination
branch
from
b11a433
to
461c1da
Compare
RandomByte
previously approved these changes
Nov 13, 2023
matz3
reviewed
Nov 13, 2023
matz3
reviewed
Nov 14, 2023
RandomByte
reviewed
Nov 14, 2023
RandomByte
reviewed
Nov 14, 2023
RandomByte
changed the title
matz3
approved these changes
Nov 15, 2023
RandomByte
approved these changes
Nov 15, 2023
d3xter666
added a commit
to SAP/ui5-project
that referenced
this pull request
Nov 15, 2023
JIRA: CPOUI5FOUNDATION-751 \@ui5/builder PR that depends on this change: SAP/ui5-builder#953 When cleaning up after tasks run, it can happen in couple cases: - When the project is build - When there's a SIGTERM signal - (Maybe) on some error We need to be able to distinguish between those cases as in some places we rely on graceful termination and cleanup. Especially, after the project has been build successfully. On the other hand when the user presses `Ctrl + C`, for example, we need to enforce the termination. This cahnge provides this context. --------- Co-authored-by: Merlin Beutlberger <m.beutlberger@sap.com> Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: SAP/ui5-tooling#894
JIRA: CPOUI5FOUNDATION-751
depends on: SAP/ui5-project#677
Workerpool needs to wait for all the active tasks to complete before terminating.