[FIX] fsInterface: Handle non-POSIX paths correctly #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomByte
force-pushed
the
fs-interface-non-posix
branch
3 times, most recently
from
34cbb37
to
23d257d
Compare
RandomByte
changed the title
RandomByte
changed the title
fs functions can be called with non-POSIX paths on non-POSIX systems. fsInterface should handle this correctly by converting any non-POSIX paths to POSIX for further UI5 FS internal processing.
RandomByte
force-pushed
the
fs-interface-non-posix
branch
from
23d257d
to
17ec5a8
Compare
RandomByte
changed the title
matz3
reviewed
Jun 18, 2019
matz3
approved these changes
Jun 18, 2019
|
@RandomByte squash required, as I've added a minor change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves issues with the JSDoc build (especially the
generateApiIndextask) on Windows.fs functions can be called with non-POSIX paths on non-POSIX systems.
fsInterface should handle this correctly by converting any non-POSIX
paths to POSIX for further UI5 FS internal processing.