feat: Add ui5lint-disable directives #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomByte
changed the title
flovogt
reviewed
Sep 30, 2024
flovogt
reviewed
Sep 30, 2024
RandomByte
force-pushed
the
add-directives
branch
2 times, most recently
from
1e3a049 to
8310167
Compare
RandomByte
force-pushed
the
add-directives
branch
3 times, most recently
from
4063044 to
04cf2de
Compare
RandomByte
force-pushed
the
add-directives
branch
5 times, most recently
from
80080f3 to
d5289b4
Compare
matz3
reviewed
Nov 8, 2024
matz3
reviewed
Nov 11, 2024
RandomByte
force-pushed
the
add-directives
branch
2 times, most recently
from
e75219f to
164380f
Compare
matz3
reviewed
Nov 12, 2024
matz3
force-pushed
the
add-directives
branch
3 times, most recently
from
af635f8 to
afb18be
Compare
RandomByte
force-pushed
the
add-directives
branch
3 times, most recently
from
43f69ad to
830b097
Compare
RandomByte
force-pushed
the
add-directives
branch
from
527bed4 to
ef13407
Compare
matz3
previously approved these changes
Nov 13, 2024
JIRA: CPOUI5FOUNDATION-911
Sources may contain the following comments to suppress reporting of findings. Both, line and block comments are supported. The comment should contain nothing but the directive, optionally followed by a description (separated using "--"). This should behave similar to ESLint's disable comments. General syntax: // ui5lint-disable(-next)(-line) rule-1, rule2 -- Description Examples: foo(); // ui5lint-disable-line // ui5lint-disable-next-line foo(); // ui5lint-disable no-deprecated-api, no-globals sap.foo(); // ui5lint-enable no-deprecated-api, no-globals /* ui5lint-disable-next-line no-deprecated-api -- To be discussed */ foo();
This ensures correct behavior when a 'ui5lint-disable-next-line' directive is spread across multiple lines (multi-line comment), where the line directly following the comment should be affected.
Co-authored-by: Matthias Oßwald <mat.osswald@sap.com>
RandomByte
force-pushed
the
add-directives
branch
from
ef13407 to
5b8b884
Compare
matz3
previously approved these changes
Nov 13, 2024
|
@KlattG we would appreciate your feedback on the new chapter in the README file: https://github.com/SAP/ui5-linter/pull/327/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5 |
flovogt
reviewed
Nov 13, 2024
There was a problem hiding this comment.
@RandomByte could you update the log output https://github.com/SAP/ui5-linter/blob/main/README.md#usage too please?
Done, thanks 👍 |
KlattG
suggested changes
Nov 13, 2024
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
matz3
approved these changes
Nov 13, 2024
KlattG
approved these changes
Nov 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sources may contain the following comments to suppress reporting of findings. Both, line and block comments are supported. The comment should contain nothing but the directive, optionally followed by a description (separated using "--").
This should behave similar to ESLint's disable comments.
General syntax:
// ui5lint-disable(-next)(-line) rule-1, rule2 -- DescriptionExamples:
JIRA: CPOUI5FOUNDATION-911
Resolves #268