fix: Improve Control Renderer lint #392
Conversation
codeworrior
changed the title
…bjectLiteralExpression
d3xter666
force-pushed
the
fix-renderer-findings
branch
from
89df70f to
3651db5
Compare
src/linter/messages.ts
Outdated
| @@ -333,6 +334,15 @@ export const MESSAGE_INFO = { | |||
| details: () => `"{@link sap.ui.core.RenderManager#methods/icon RenderManager}",`, | |||
| }, | |||
|
|
|||
| [MESSAGE.NOT_STATIC_CONTROL_RENDERER]: { | |||
| severity: LintMessageSeverity.Warning, | |||
| ruleId: RULES["no-deprecated-api"], | |||
There was a problem hiding this comment.
I wouldn't expect this an deprecated API, as it never was intended to be defined that way. Therefore I think we should use a different ruleId. Also, it is not related to UI5 2.x, but a general check.
There was a problem hiding this comment.
True, thanks!
But, to me this one seems too specific. Would static-var-required be ok, then?
There was a problem hiding this comment.
Maybe ui5-class-declaration, as it is about how UI5 classes are declared/defined.
What do you think @codeworrior / @flovogt / @RandomByte ?
There was a problem hiding this comment.
just another idea ui5-control-definition?
There was a problem hiding this comment.
As the renderer is not a general concept for UI5 classes, I rather tend to ui5-control-declaration. But there might not be much in addition to this check that would justify a separate rule-ID for that. So I would be fine with ui5-class-declaration, too.
There was a problem hiding this comment.
Changed it to ui5-class-declaration. Let me know if something else comes
@sapui5/types