Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] specVersion 3.0 #522

Merged
merged 19 commits into from
Dec 20, 2022
Merged

[FEATURE] specVersion 3.0 #522

merged 19 commits into from
Dec 20, 2022

Conversation

d3xter666
Copy link
Contributor

JIRA: CPOUI5FOUNDATION-473

@coveralls
Copy link

coveralls commented Dec 6, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 94.916% when pulling 456e2c8 on specVersion-3.0 into 2c0ef1a on main.

@d3xter666 d3xter666 changed the title [DRAFT] specVersion 3.0 [INTERNAL] specVersion 3.0 Dec 9, 2022
@matz3 matz3 mentioned this pull request Dec 12, 2022
Merged
matz3
matz3 requested changes Dec 12, 2022
View reviewed changes
Copy link
Member

@matz3 matz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New tests for changes in specVersion 3.0 missing

lib/validation/schema/specVersion/kind/project.json Show resolved Hide resolved
@d3xter666
Copy link
Contributor Author

New tests for changes in specVersion 3.0 missing

There are now tests to cover the new/modified properties

@d3xter666 d3xter666 requested a review from matz3 December 13, 2022 13:51
@d3xter666 d3xter666 requested a review from matz3 December 15, 2022 06:52
@flovogt
Copy link
Member

flovogt commented Dec 15, 2022

LGTM

@matz3
Copy link
Member

matz3 commented Dec 19, 2022

LGTM. Please use the [FEATURE] tag for title and commit message.

@d3xter666 d3xter666 merged commit c5070e5 into main Dec 20, 2022
@d3xter666 d3xter666 deleted the specVersion-3.0 branch December 20, 2022 09:11
@flovogt flovogt mentioned this pull request Dec 20, 2022
Closed
17 tasks
@matz3 matz3 changed the title [INTERNAL] specVersion 3.0 [FEATURE] specVersion 3.0 Dec 20, 2022
d3xter666 added a commit that referenced this pull request Feb 7, 2023
@d3xter666
[FEATURE] specVersion 3.0 (#522)
4aac10b 
Adds schema support for UI5 Tooling v3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matz3 matz3 matz3 approved these changes

@flovogt flovogt Awaiting requested review from flovogt

@RandomByte RandomByte Awaiting requested review from RandomByte

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@d3xter666 @coveralls @flovogt @matz3