[FEATURE] Add specVersion 3.1 and builder resource excludes for modules #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically a copy of the 'application' type but with the same path mappings as 'library' (directories: 'src' and 'test') and a namespaced runtime path. JIRA: CPOUI5FOUNDATION-27
Might not be part of specVersion 3.1
RandomByte
force-pushed
the
add-specVersion-3.1
branch
from
c75bb03
to
9e1e665
Compare
RandomByte
changed the title
RandomByte
added a commit
that referenced
this pull request
Aug 10, 2023
RandomByte
added a commit
to SAP/ui5-tooling
that referenced
this pull request
Aug 11, 2023
This configuration will enabled by SAP/ui5-project#639
flovogt
requested changes
Aug 14, 2023
matz3
requested changes
Aug 18, 2023
Comment on lines
+431
to
+436
| "resources": { | ||
| "excludes": [ | ||
| "/resources/some/project/name/test_results/**", | ||
| "!/test-resources/some/project/name/demo-app/**" | ||
| ] | ||
| } |
There was a problem hiding this comment.
What about settings? They are now also allowed. Was this intended?
Comment on lines
+195
to
+197
| "settings": { | ||
| "$ref": "../project.json#/definitions/builder-settings" | ||
| } |
There was a problem hiding this comment.
I think this also makes sense to add, but we never talked about it, right?
There was a problem hiding this comment.
Settings were already allowed before. See https://github.com/SAP/ui5-project/pull/639/files#diff-7b0836b8d51420484c25fc8977caba9234b6efc7193d3f0507731f291f8362beR183 and https://github.com/SAP/ui5-project/pull/639/files#diff-a21c72474996eb0b320d874991042a771b23940e75ce1ce9344261143d8bf875R184
Co-authored-by: Florian Vogt <florian.vogt@sap.com>
matz3
approved these changes
Aug 18, 2023
Comment on lines
+431
to
+436
| "resources": { | ||
| "excludes": [ | ||
| "/resources/some/project/name/test_results/**", | ||
| "!/test-resources/some/project/name/demo-app/**" | ||
| ] | ||
| } |
Comment on lines
+195
to
+197
| "settings": { | ||
| "$ref": "../project.json#/definitions/builder-settings" | ||
| } |
flovogt
approved these changes
Aug 21, 2023
RandomByte
added a commit
to SAP/ui5-tooling
that referenced
this pull request
Aug 22, 2023
This configuration will enabled by SAP/ui5-project#639
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #623 but with the component type removed again.
JIRA: CPOUI5FOUNDATION-561