[FEATURE] TaskUtil: Add 'force' flag to cleanup task callback #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomByte
reviewed
Nov 10, 2023
RandomByte
reviewed
Nov 10, 2023
Co-authored-by: Merlin Beutlberger <m.beutlberger@sap.com>
RandomByte
requested changes
Nov 13, 2023
RandomByte
previously approved these changes
Nov 14, 2023
|
Maybe we should have this as a |
|
We should also update the JSDoc in TaskUtil: https://github.com/SAP/ui5-project/blob/main/lib/build/helpers/TaskUtil.js#L175 |
d3xter666
changed the title
I have added JSDoc for the TaskUtil's cleanup callback. @KlattG would you take a look, please? |
RandomByte
previously approved these changes
Nov 14, 2023
RandomByte
changed the title
matz3
requested changes
Nov 14, 2023
matz3
reviewed
Nov 14, 2023
Update JSDoc
KlattG
suggested changes
Nov 14, 2023
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
matz3
approved these changes
Nov 15, 2023
RandomByte
approved these changes
Nov 15, 2023
d3xter666
added a commit
to SAP/ui5-builder
that referenced
this pull request
Nov 17, 2023
…953) fixes: SAP/ui5-tooling#894 JIRA: CPOUI5FOUNDATION-751 depends on: SAP/ui5-project#677 Workerpool needs to wait for all the active tasks to complete before terminating. --------- Co-authored-by: Merlin Beutlberger <m.beutlberger@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: CPOUI5FOUNDATION-751
@ui5/builder PR that depends on this change: SAP/ui5-builder#953
When cleaning up after tasks run, it can happen in couple cases:
We need to be able to distinguish between those cases as in some places we rely on graceful termination and cleanup. Especially, after the project has been build successfully. On the other hand when the user presses
Ctrl + C, for example, we need to enforce the termination.This cahnge provides this context.