Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Node.js API: TypeScript type definition support #334

Merged
merged 2 commits into from
Jul 14, 2020
Merged

Conversation

matz3
Copy link
Member

@matz3 matz3 commented Jun 24, 2020

Lazy-loading breaks the automatic type definition detection from

TypeScript. Therefore we need to manually declare the exported types.

Lazy-loading breaks the automatic type definition detection from

TypeScript. Therefore we need to manually declare the exported types.
@coveralls
Copy link

coveralls commented Jun 24, 2020

Coverage Status

Coverage decreased (-0.4%) to 92.873% when pulling ebecd42 on fix-ts-support into 6f73557 on master.

@RandomByte
Copy link
Member

CI is not happy:

ERROR: Unable to parse a tag's type expression for source file /home/vsts/work/1/s/index.js in line 6 with tag title "type" and text "{import('./lib/server')}": Invalid type expression "import('./lib/server')": Expected "!", "=", "?", "[]", "|", or end of input but "(" found.
ERROR: Unable to parse a tag's type expression for source file /home/vsts/work/1/s/index.js in line 9 with tag title "type" and text "{import('./lib/server')}": Invalid type expression "import('./lib/server')": Expected "!", "=", "?", "[]", "|", or end of input but "(" found.
ERROR: Unable to parse a tag's type expression for source file /home/vsts/work/1/s/index.js in line 10 with tag title "type" and text "{import('./lib/sslUtil')}": Invalid type expression "import('./lib/sslUtil')": Expected "!", "=", "?", "[]", "|", or end of input but "(" found.
ERROR: Unable to parse a tag's type expression for source file /home/vsts/work/1/s/index.js in line 13 with tag title "type" and text "{import('./lib/sslUtil')}": Invalid type expression "import('./lib/sslUtil')": Expected "!", "=", "?", "[]", "|", or end of input but "(" found.
ERROR: Unable to parse a tag's type expression for source file /home/vsts/work/1/s/index.js in line 14 with tag title "type" and text "{import('./lib/middleware/middlewareRepository')}": Invalid type expression "import('./lib/middleware/middlewareRepository')": Expected "!", "=", "?", "[]", "|", or end of input but "(" found.
ERROR: Unable to parse a tag's type expression for source file /home/vsts/work/1/s/index.js in line 17 with tag title "type" and text "{import('./lib/middleware/middlewareRepository')}": Invalid type expression "import('./lib/middleware/middlewareRepository')": Expected "!", "=", "?", "[]", "|", or end of input but "(" found.

@matz3
Copy link
Member Author

matz3 commented Jul 14, 2020

The jsdoc-plugin.js from SAP/ui5-fs#252 is missing here

@matz3 matz3 requested a review from RandomByte July 14, 2020 07:39
Copy link
Member

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a more precise commit message would be good if possible

@matz3 matz3 merged commit b66f9cc into master Jul 14, 2020
@matz3 matz3 deleted the fix-ts-support branch July 14, 2020 11:57
@matz3 matz3 changed the title [FIX] TypeScript type definition support [FIX] Node.js API: TypeScript type definition support Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants