[FIX] Discovery middleware shouldn't fail when lib names overlap #362
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a library's name is a prefix of another library's name (like with
sap.m and sap.me), the discovery service mistakenly assigned test pages
to both libraries.
By including the slash in the prefix check, only full segment matches
will be taken into account.
By checking the prefixes from longest to shortest and by aborting after
the first match, non-prefix-free lib names can be handled properly. The
longest matching prefix will win and there won't be double assignments.
Thank you for your contribution! 🙌
To get it merged faster, kindly review the checklist below:
Pull Request Checklist