-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING] Remove "/proxy" endpoint #550
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomByte
added a commit
to SAP/ui5-tooling
that referenced
this pull request
Nov 30, 2022
17 tasks
BREAKING CHANGE: This removes the "/proxy" endpoint and the corresponding "connectUi5Proxy" middleware from the standard ui5-server. Internally, this middleware made use of the connect-openui5 proxy implementation (https://github.com/SAP/connect-openui5#proxy). More sophisticated proxy solutions for ui5-server are already available in the form of custom middleware extensions from the UI5-community. The UI5 Team might provide a dedicated custom middleware extension, with similar functionality, in the future.
RandomByte
force-pushed
the
remove-connect-openui5
branch
from
December 1, 2022 15:32
b57d303
to
6d69954
Compare
matz3
reviewed
Dec 19, 2022
flovogt
reviewed
Dec 21, 2022
flovogt
requested changes
Dec 21, 2022
flovogt
approved these changes
Dec 21, 2022
d3xter666
added a commit
to SAP/ui5-tooling
that referenced
this pull request
Dec 23, 2022
Relates to: SAP/ui5-server#550 JIRA: CPOUI5FOUNDATION-598
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
This removes the "/proxy" endpoint and the corresponding
"connectUi5Proxy" middleware from the standard ui5-server.
Internally, this middleware made use of the connect-openui5 proxy
implementation (https://github.com/SAP/connect-openui5#proxy).
More sophisticated proxy solutions for ui5-server are already available
in the form of custom middleware extensions from the UI5-community.
The UI5 Team might provide a dedicated custom middleware extension,
with similar functionality, in the future.
JIRA: CPOUI5FOUNDATION-598