Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] Remove "/proxy" endpoint #550

Merged
merged 9 commits into from
Dec 21, 2022
Merged

[BREAKING] Remove "/proxy" endpoint #550

merged 9 commits into from
Dec 21, 2022

Conversation

RandomByte
Copy link
Member

@RandomByte RandomByte commented Nov 30, 2022

BREAKING CHANGE:
This removes the "/proxy" endpoint and the corresponding
"connectUi5Proxy" middleware from the standard ui5-server.
Internally, this middleware made use of the connect-openui5 proxy
implementation (https://github.com/SAP/connect-openui5#proxy).

More sophisticated proxy solutions for ui5-server are already available
in the form of custom middleware extensions from the UI5-community.

The UI5 Team might provide a dedicated custom middleware extension,
with similar functionality, in the future.

JIRA: CPOUI5FOUNDATION-598

@coveralls
Copy link

coveralls commented Nov 30, 2022

Coverage Status

Coverage increased (+0.2%) to 93.326% when pulling 5e70fec on remove-connect-openui5 into 70e859f on main.

RandomByte added a commit to SAP/ui5-tooling that referenced this pull request Nov 30, 2022
@RandomByte RandomByte marked this pull request as ready for review December 1, 2022 11:11
@flovogt flovogt self-requested a review December 1, 2022 13:31
BREAKING CHANGE:
This removes the "/proxy" endpoint and the corresponding
"connectUi5Proxy" middleware from the standard ui5-server.
Internally, this middleware made use of the connect-openui5 proxy
implementation (https://github.com/SAP/connect-openui5#proxy).

More sophisticated proxy solutions for ui5-server are already available
in the form of custom middleware extensions from the UI5-community.

The UI5 Team might provide a dedicated custom middleware extension,
with similar functionality, in the future.
@d3xter666 d3xter666 merged commit 4bdf839 into main Dec 21, 2022
@d3xter666 d3xter666 deleted the remove-connect-openui5 branch December 21, 2022 12:54
d3xter666 added a commit to SAP/ui5-tooling that referenced this pull request Dec 23, 2022
@d3xter666 d3xter666 mentioned this pull request Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants