-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenUI5's legacy tooling breaks when linking to @ui5/server 1.1.0 #341
Comments
This is also a problem when using npm instead of yarn to install the dependencies in the OpenUI5 repository. Since we only provide a |
Would it be an option to use To me, reverting back seems to be the least expensive option. |
As discussed, let's revert back to manual parsing to keep compatibility with the current grunt tooling that is based on connect. |
With change 4f05967, the CSP middleware made use of 'express' APIs on the request object. When used in an environment without 'express' (e.g. the OpenUI5 legacy grunt tooling), the CSP middleware failed for all requests. It now uses the native NodeJS APIs again. Fixes https://github.com/SAP/ui5-server/issues/183 .
…ver (#184) * [FIX] Makes CSP middleware work in an environment without express server With change 4f05967, the CSP middleware made use of 'express' APIs on the request object. When used in an environment without 'express' (e.g. the OpenUI5 legacy grunt tooling), the CSP middleware failed for all requests. It now uses the native NodeJS APIs again. Fixes https://github.com/SAP/ui5-server/issues/183 . * adapt tests
Expected Behavior
When I link from
openui5
to the latest release of theui5-tooling
, I expect thatgrunt serve
continues to work.Current Behavior
grunt serve
starts but fails for each request and responds with an error stack trace (see below).I unfortunately caused the issue myself with PR SAP/ui5-server#179 as I relied on
express
APIs in thecsp
middleware (request.path
andrequest.params
). But in the context ofgrunt serve
,express
is obviously not used and the APIs are missing.Steps to reproduce the issue
openui5
andui5-tooling
openui5
to@ui5/server
at leastgrunt serve
and open any HTML pageAffected components (if known)
Log Output / Stack Trace
The text was updated successfully, but these errors were encountered: