Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content of splitted modules differ each build #385

Closed
1 of 6 tasks
devtomtom opened this issue Apr 27, 2018 · 1 comment
Closed
1 of 6 tasks

Content of splitted modules differ each build #385

devtomtom opened this issue Apr 27, 2018 · 1 comment
Labels
enhancement New feature or request module/ui5-builder Related to the UI5 Builder module

Comments

@devtomtom
Copy link
Member

Expected Behavior

When splitting modules in different parts by setting the numberOfParts property in the ui5.yaml, it is expected that the resulting modules are always the same.

Current Behavior

The resulting parts differ each time when building the project depending on the file sizes.

Steps to reproduce the issue

  1. clone the project ui5-builder
  2. adapt libraryHTree in test/lib/builder/builder.js to
const libraryHTree = {
	"id": "library.h",
	"version": "1.0.0",
	"path": libraryHPath,
	"dependencies": [],
	"_level": 0,
	"specVersion": "0.1",
	"type": "library",
	"metadata": {
		"name": "library.h",
		"copyright": "Some fancy copyright"
	},
	"resources": {
		"configuration": {
			"paths": {
				"src": "main/src",
				"test": "main/test"
			}
		},
		"pathMappings": {
			"/resources/": "main/src",
			"/test-resources/": "main/test"
		}
	},
	"builder": {
		"bundles": [{
			"bundleDefinition": {
				"name": "library/h/customBundle.js",
				"defaultFileTypes": [".js"],
				"sections": [{
					"mode": "preload",
					"filters": [
						"library/h/some.js",
						"library/h/library.js",
						"library/h/file.js",
						"!library/h/not.js"
					],
					"resolve": false,
					"renderer": false
				}]
			},
			"bundleOptions": {
				"optimize": true,
				"usePredefinedCalls": true,
                                 "numberOfParts": 4
			}
		}],
		"componentPreload": [
			"components",
			"components/subcomponent1",
			"components/subcomponent2",
			"components/subcomponent3",
		]
	}
};
  1. run npm run unit-inspect test/lib/builder/builder.js

Context

  • OS/Platform: MacOS
  • Node.js Version: v.8.10.0
  • npm Version: 5.6.0

Affected components

@RandomByte RandomByte transferred this issue from SAP/ui5-builder Nov 20, 2020
@RandomByte RandomByte added enhancement New feature or request module/ui5-builder Related to the UI5 Builder module labels Nov 20, 2020
@matz3
Copy link
Member

matz3 commented Sep 26, 2022

Solved via SAP/ui5-builder#689, released as v3.0.0-alpha.1

@matz3 matz3 closed this as completed Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module/ui5-builder Related to the UI5 Builder module
Projects
None yet
Development

No branches or pull requests

3 participants