Skip to content

[a11y | SelectDialog]: headerText is not read by VoiceOver #7319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
volha-arkhipenka-sap opened this issue May 7, 2025 · 11 comments · Fixed by #7327
Closed
1 task done

[a11y | SelectDialog]: headerText is not read by VoiceOver #7319

volha-arkhipenka-sap opened this issue May 7, 2025 · 11 comments · Fixed by #7327

Comments

@volha-arkhipenka-sap
Copy link

volha-arkhipenka-sap commented May 7, 2025

Bug Description

With Voiceover enabled, on opening SelectDialog the title provided in headerText is not read by VoiceOver.

Affected Component

SelectDialog https://sap.github.io/ui5-webcomponents-react/v2/?path=/docs/modals-popovers-selectdialog--docs

Expected Behaviour

All SelectDialog content and information should be conveyed to a user.

Isolated Example

Reproducible with VoiceOver enabled on https://sap.github.io/ui5-webcomponents-react/v2/?path=/docs/modals-popovers-selectdialog--docs

Steps to Reproduce

  1. Provide headerText prop to SelectDialog component
  2. Enable VoiceOver
  3. Open SelectDialog component
  4. headerText is not announced

Log Output, Stack Trace or Screenshots

Image

Priority

None

UI5 Web Components Version

2.9.0

Browser

Chrome

Operating System

macOS Sequoia 15.4.1

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@AlekseiSch
Copy link

Also reproducible for NVDA
Image

@NakataCode
Copy link

NakataCode commented May 8, 2025

Hi @volha-arkhipenka-sap,

I tested the <ui5-dialog> component directly using the Playground with header-text provided, and observed that VoiceOver does read the header, as long as the initial focus is placed on it. You can check the test example here.

According to the spec, the dialog header should be announced on focus, so the behavior depends on where the focus lands upon dialog open. In your example, the initial focus is set on the first item inside the dialog, not on the header, which likely explains why VoiceOver doesn’t announce it.

I’m going to proceed with closing this ticket for now. If any further questions arise or you need clarification, feel free to reopen it.

Best regards,
Nikola

Copy link

github-actions bot commented May 8, 2025

This issue has been closed. To reopen, just leave a comment!

@github-actions github-actions bot reopened this May 8, 2025
Copy link

github-actions bot commented May 8, 2025

This issue has been closed. To reopen, just leave a comment!

@volha-arkhipenka-sap
Copy link
Author

Hi @NakataCode, thank you for the response.

However, when SelectDialog contains ListItemStandards, the focus is set on the first item automatically by SelectDialog. This focus behavoir seems to be default and internal for SelectDialog component when it has a list of ListItemStandards inside. The focus lands on the first ListItemStandard even in the example from the documentation https://sap.github.io/ui5-webcomponents-react/v2/?path=/docs/modals-popovers-selectdialog--docs.

Should it be considered as a bug of incorrect focus landing on SelectDialog open?

@NakataCode
Copy link

Hello @SAP/ui5-webcomponents-topic-rd,

Could you please take over this issue?

Best regards,
Nikola

@LidiyaGeorgieva
Copy link

Hello @Lukas742,

It looks that this should be fixed in the Select Dialog, where slot "header" is used, but "accessibleName" is not provided.
See the documentation of the DIalog: https://sap.github.io/ui5-webcomponents/nightly/components/Dialog/#header

Best Regards,
Lidiya

@LidiyaGeorgieva
Copy link

@volha-arkhipenka-sap for issues related with the ui5-webcomponents-react project you should open GitHub issues on this project (not on ui5-webcomponents project)

@volha-arkhipenka-sap volha-arkhipenka-sap changed the title [a11y][SelectDialog]: headerText is not read by VoiceOver [a11y | SelectDialog]: headerText is not read by VoiceOver May 9, 2025
@Lukas742
Copy link
Contributor

Lukas742 commented May 9, 2025

Hi @LidiyaGeorgieva

thanks for letting me know! I'll move this issue to our repo.


Hi @volha-arkhipenka-sap

until an accessible name is available out of the box, you can set it yourself via the accessibleName prop.

@ui5-webcomponents-react-bot
Copy link
Contributor

🎉 This issue has been resolved in version v2.11.0-rc.0 🎉

The release is available on v2.11.0-rc.0

Your semantic-release bot 📦🚀

@Lukas742 Lukas742 removed the released label May 16, 2025
@ui5-webcomponents-react-bot
Copy link
Contributor

🎉 This issue has been resolved in version v2.10.1 🎉

The release is available on v2.10.1

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

6 participants