fix(ui5-flexible-column-layout): Fix arrow misplacement in IE (#2032)

Fixes: #1998
SAP · Aug 3, 2020 · 57be7c2 · 57be7c2
1 parent 7f99be5
commit 57be7c2
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/packages/fiori/src/FlexibleColumnLayout.hbs b/packages/fiori/src/FlexibleColumnLayout.hbs
@@ -1,4 +1,4 @@
-<div class="ui5-fcl-root">
+<div class="{{classes.root}}">
 	<div
 		role="region"
 		class="{{classes.columns.start}}"

diff --git a/packages/fiori/src/FlexibleColumnLayout.js b/packages/fiori/src/FlexibleColumnLayout.js
@@ -6,6 +6,7 @@ import Integer from "@ui5/webcomponents-base/dist/types/Integer.js";
 import { fetchI18nBundle, getI18nBundle } from "@ui5/webcomponents-base/dist/i18nBundle.js";
 import AnimationMode from "@ui5/webcomponents-base/dist/types/AnimationMode.js";
 import { getAnimationMode } from "@ui5/webcomponents-base/dist/config/AnimationMode.js";
+import { isIE } from "@ui5/webcomponents-base/dist/Device.js";
 import Button from "@ui5/webcomponents/dist/Button.js";
 import "@ui5/webcomponents-icons/dist/icons/slim-arrow-left.js";
 import "@ui5/webcomponents-icons/dist/icons/slim-arrow-right.js";
@@ -490,6 +491,10 @@ class FlexibleColumnLayout extends UI5Element {
 		const hasAnimation = getAnimationMode() !== AnimationMode.None;
 
 		return {
+			root: {
+				"ui5-fcl-root": true,
+				"ui5-fcl--ie": isIE(),
+			},
 			columns: {
 				start: {
 					"ui5-fcl-column": true,

diff --git a/packages/fiori/src/themes/FlexibleColumnLayout.css b/packages/fiori/src/themes/FlexibleColumnLayout.css
@@ -100,3 +100,12 @@
 .ui5-fcl-arrow:hover:after {
 	height: 7rem;
 }
+
+/*
+ * IE FIX:
+ * The column separator, that is also the arrow container, is 1rem,
+ * whereas the arrow button is 1.5rem and the arrows just doesnt center within the 
+*/
+.ui5-fcl--ie .ui5-fcl-arrow {
+	margin: 0 -0.75rem;
+}