fix(ui5-input): Suggestions can now be arbitrary list items (#1969)

SAP · Jul 28, 2020 · f3b0567 · f3b0567
1 parent a75c96d
commit f3b0567
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/packages/main/src/Input.js b/packages/main/src/Input.js
@@ -802,18 +802,19 @@ class Input extends UI5Element {
 	}
 
 	previewSuggestion(item) {
-		const emptyValue = item.type === "Inactive" || item.group;
 		this.valueBeforeItemSelection = this.value;
-		this.updateValueOnPreview(emptyValue ? "" : item.effectiveTitle);
+		this.updateValueOnPreview(item);
 		this.announceSelectedItem();
 		this._previewItem = item;
 	}
 
 	/**
 	 * Updates the input value on item preview.
-	 * @param {itemValue} itemValue The value of the item that is on preview
+	 * @param {Object} item The item that is on preview
 	 */
-	updateValueOnPreview(itemValue) {
+	updateValueOnPreview(item) {
+		const noPreview = item.type === "Inactive" || item.group;
+		const itemValue = noPreview ? "" : (item.effectiveTitle || item.textContent);
 		this.value = itemValue;
 	}
 

diff --git a/packages/main/src/features/InputSuggestions.js b/packages/main/src/features/InputSuggestions.js
@@ -318,7 +318,7 @@ class Suggestions {
 	}
 
 	_getItems() {
-		return [].slice.call(this.responsivePopover.querySelectorAll("ui5-li-groupheader, ui5-li-suggestion-item"));
+		return [...this.responsivePopover.querySelectorAll("ui5-list>*")];
 	}
 
 	_getComponent() {