Skip to content

Commit

Permalink
feat(ui5-flexible-column-layout): add start/mid/endColumnAccessibleNa…
Browse files Browse the repository at this point in the history
…me properties (#2483)
  • Loading branch information
fifoosid authored Nov 30, 2020
1 parent b5c4a92 commit fb0b24c
Show file tree
Hide file tree
Showing 2 changed files with 45 additions and 4 deletions.
42 changes: 39 additions & 3 deletions packages/fiori/src/FlexibleColumnLayout.js
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,42 @@ const metadata = {
type: Boolean,
},

/**
* Defines the accessibility name for the <code>startColumn</code> region.
*
* @type {string}
* @defaultvalue ""
* @public
* @since 1.0.0-rc.11
*/
startColumnAccessibleName: {
type: String,
},

/**
* Defines the accessibility name for the <code>midColumn</code> region.
*
* @type {string}
* @defaultvalue ""
* @public
* @since 1.0.0-rc.11
*/
midColumnAccessibleName: {
type: String,
},

/**
* Defines the accessibility name for the <code>endColumn</code> region.
*
* @type {string}
* @defaultvalue ""
* @public
* @since 1.0.0-rc.11
*/
endColumnAccessibleName: {
type: String,
},

/**
* Defines the component width in px.
*
Expand Down Expand Up @@ -620,15 +656,15 @@ class FlexibleColumnLayout extends UI5Element {
}

get accStartColumnText() {
return this.i18nBundle.getText(FCL_START_COLUMN_TXT);
return this.startColumnAccessibleName || this.i18nBundle.getText(FCL_START_COLUMN_TXT);
}

get accMiddleColumnText() {
return this.i18nBundle.getText(FCL_MIDDLE_COLUMN_TXT);
return this.midColumnAccessibleName || this.i18nBundle.getText(FCL_MIDDLE_COLUMN_TXT);
}

get accEndColumnText() {
return this.i18nBundle.getText(FCL_END_COLUMN_TXT);
return this.endColumnAccessibleName || this.i18nBundle.getText(FCL_END_COLUMN_TXT);
}

get _effectiveLayoutsByMedia() {
Expand Down
7 changes: 6 additions & 1 deletion packages/fiori/test/pages/FCLApp.html
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,12 @@
</ui5-shellbar>

<!--- FLEXIBLE COLUMN LAYOUT -->
<ui5-flexible-column-layout id="fcl">
<ui5-flexible-column-layout
id="fcl"
start-column-accessible-name="Companies list"
mid-column-accessible-name="Products List"
end-column-accessible-name="Product Details"
>
<div class="column" id="startColumn" slot="startColumn">
<ui5-busyindicator id="startBusy">
<div class="ui5-message-page">
Expand Down

0 comments on commit fb0b24c

Please sign in to comment.