Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: SAP/ui5-webcomponents
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.2.1
Choose a base ref
...
head repository: SAP/ui5-webcomponents
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Loading
Showing 4,820 changed files with 259,757 additions and 124,215 deletions.
The diff you're trying to view is too large. We only load the first 3000 changed files.
3 changes: 2 additions & 1 deletion .editorconfig
Original file line number Diff line number Diff line change
@@ -5,9 +5,10 @@ root = true
[*]
charset = utf-8

[*.{css,html,java,js,json,less,txt}]
[*.{css,html,java,js,json,less,txt,ts}]
trim_trailing_whitespace = true
end_of_line = lf
indent_style = tab
tab_width = 4

[pom.xml]
2 changes: 2 additions & 0 deletions .env.development
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
VITE_BUNDLE_PATH="../../src/bundle.esm.ts"
VITE_BUNDLE_PATH_SCOPED="../../../src/bundle.scoped.esm.ts"
2 changes: 0 additions & 2 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
* -text
*.woff binary
*.ttf binary
*.eot binary
48 changes: 0 additions & 48 deletions .github/ISSUE_TEMPLATE/bug_report.md

This file was deleted.

135 changes: 135 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,135 @@
name: Bug Report
description: File a bug report
title: '[component name | framework | build | icons | theming | localization | i18n | typescript]:'
labels: ["bug"]
assignees: []
body:
- type: textarea
id: description
attributes:
label: Bug Description
description: A clear and concise description of what the bug is.
validations:
required: true
- type: input
id: component
attributes:
label: Affected Component
validations:
required: false
- type: textarea
id: expectation
attributes:
label: Expected Behaviour
description: A clear and concise description of what you expect to happen.
validations:
required: false
- type: input
id: example
attributes:
label: Isolated Example
description: Please provide a link to an isolated example if possible by forking [this stackblitz](https://stackblitz.com/edit/js-vsrpnb?file=index.js,index.html).
validations:
required: false
- type: textarea
id: repro
attributes:
label: Steps to Reproduce
description: How do you trigger this bug? Please walk us through it step by step.
value: |
1.
2.
3.
...
validations:
required: false
- type: textarea
id: logs
attributes:
label: Log Output, Stack Trace or Screenshots
description: |
If applicable, add log output, screenshots, or a video to help explain your problem.
For more information on the supported file image/file types and the file size limits, please refer
to the following link: https://docs.github.com/en/github/writing-on-github/working-with-advanced-formatting/attaching-files
placeholder: |
You can drag your video or image files inside of this editor ↓
validations:
required: false
- type: dropdown
id: priority
attributes:
label: Priority
description: |
The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:
- Breaks entire application or system - High or Very High
- Accessibility issue - Medium or High
- Functional issue - Medium or High
- Visual issue - Low or Medium
multiple: false
options:
- Low
- Medium
- High
- Very High
validations:
required: false

- type: markdown
attributes:
value: '## Environment Info'
- type: input
id: version
attributes:
label: UI5 Web Components Version
validations:
required: true
- type: dropdown
id: browser
attributes:
label: Browser
multiple: true
options:
- Chrome
- Edge
- Firefox
- Safari
validations:
required: true
- type: input
id: os
attributes:
label: Operating System
validations:
required: false

- type: markdown
attributes:
value: '## Additional Info'
- type: textarea
id: additional-context
attributes:
label: Additional Context
description: Add business impact or any other context about the problem here.

- type: input
id: org
attributes:
label: Organization
description: Add your organization name.
validations:
required: false

- type: markdown
attributes:
value: |
## Privacy Policy
Please don't disclose any internal or sensitive information like: internal urls, login credentials, screenshots of applications or features in development.
This is a public GitHub repository and all the information is publicly available.
- type: checkboxes
id: confirmation
attributes:
label: Declaration
description: By submitting this issue, I confirm to follow the recommendation not to disclose any internal or sensitive information.
options:
- label: I’m not disclosing any internal or sensitive information.
required: true
30 changes: 0 additions & 30 deletions .github/ISSUE_TEMPLATE/feature_request.md

This file was deleted.

66 changes: 66 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
name: Feature Request
description: Request a new feature or enhancement for this project
title: '[Feature Request]:'
assignees: []
body:
- type: textarea
id: description
attributes:
label: Feature Request Description
description: A clear and concise description of what feature is missing.
validations:
required: true

- type: textarea
id: solution
attributes:
label: Proposed Solution
description: A clear and concise description of the solution you would like to have.
validations:
required: true

- type: textarea
id: alternative
attributes:
label: Proposed Alternatives
description: A clear and concise description of any alternative solutions or features you've considered.
validations:
required: false

- type: input
id: org
attributes:
label: Organization
description: Add your organization name.
validations:
required: false

- type: textarea
id: context
attributes:
label: Additional Context
description: Add other context (f.e business impact), related to the feature request.
validations:
required: false

- type: dropdown
id: priority
attributes:
label: 'Priority'
multiple: false
options:
- Low
- Medium
- High
- Very High
validations:
required: false

- type: checkboxes
id: confirmation
attributes:
label: Privacy Policy
description: By submitting this issue, I confirm to follow the recommendation not to disclose any internal or sensitive information (internal urls, login credentials, screenshots of applications or features in development).
options:
- label: I’m not disclosing any internal or sensitive information.
required: true
19 changes: 13 additions & 6 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,16 @@
**Thank you for your contribution!** 👏

To get it merged faster, kindly review the checklist below:

## Pull Request Checklist
- [ ] Reviewed the [Contributing Guidelines](https://github.com/SAP/ui5-webcomponents/blob/master/CONTRIBUTING.md)
+ Especially the [How to Contribute](https://github.com/SAP/ui5-webcomponents/blob/master/CONTRIBUTING.md#how-to-contribute) section
- [ ] [Correct commit message style](https://github.com/SAP/ui5-webcomponents/blob/master/docs/6-contributing/02-conventions-and-guidelines.md#commit-message-style)
+ Bugfixes should generally include a test to cover the issue.
### PR checklist
- [ ] Follow the [Commit message Guidelines](https://github.com/SAP/ui5-webcomponents/blob/main/docs/6-contributing/02-conventions-and-guidelines.md#commit-message-style)

For example: `fix(ui5-*): correct/fix sth` or `feat(ui5-*): add/introduce sth`. If you don't want the change to be part of the release changelog - use `chore`, `refactor` or `docs`.

- [ ] Add proper description about the background of the change and the change itself

- [ ] Link to an existing issue (if available)

Use `Fixes: {#PR_NUMBER}` to close the issue automatically when the PR is merged
or `Related to: {#PR_NUMBER}` to just create a link between the PR and the issue.

- [ ] Read the [Contributing Guidelines](https://github.com/SAP/ui5-webcomponents/blob/main/CONTRIBUTING.md)
28 changes: 28 additions & 0 deletions .github/actions/createIssueComments.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
const commitShaRegExp = /commit\/(?<sha>\w{40})/gm;

module.exports = async function run({
github,
context,
version
}) {
const {
data: release
} = await github.repos.getReleaseByTag({
owner: context.repo.owner,
repo: context.repo.repo,
tag: `v${version}`
});
release.url = release.html_url;

console.log(release);
// const commits = [];
// let result;
// do {
// result = commitShaRegExp.exec(release.body);
// if (result && result.groups && result.groups.sha) {
// commits.push({
// hash: result.groups.sha
// });
// }
// } while (result);
};
Loading