Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SF][DynamicPage]: Subheading is only taking part of the width of whole header #10127

Closed
1 task done
summer2200 opened this issue Nov 1, 2024 · 4 comments
Closed
1 task done
Assignees
Labels
bug This issue is a bug in the code Medium Prio SAP SF TOPIC P

Comments

@summer2200
Copy link

Bug Description

UI5 DynamicPage(will provide sample link separately) subheading is taking 100% width of the whole header part, while 2.0 version of ui5-webcomponents DynamicPage's subheading is only taking part of header's width.
Screenshot 2024-11-01 at 15 56 41

Raising this issue because our module's design was based on UI5 DynamicPage and we have elements placed in subheading which needs 100% width of header part so they can fit. All of our developments are completed in 2411. But after upgrading to v2.0, our page's style was broken due to this change.

Affected Component

No response

Expected Behaviour

No response

Isolated Example

No response

Steps to Reproduce

...

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

2.3.0

Browser

Chrome

Operating System

macOS Sonoma 14.6.1

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@summer2200 summer2200 added the bug This issue is a bug in the code label Nov 1, 2024
@dimovpetar dimovpetar self-assigned this Nov 1, 2024
@dimovpetar
Copy link
Contributor

@summer2200 I assume that you are using UI5 WebComponents for React.

Hello @SAP/ui5-webcomponents-topic-p ,

In UI5 Web Components for React V1, DynamicPage sample uses custom layout, where the subheading takes 100% of page width. Now, In UI5 Web Components for React V2, our DynamicPage is used. In this case, the subheading slot has smaller width. Please check if this is by design. Can be observed here or in UI5 WebComponents for React's Playground .

Best regards,
Petar

@ishk99
Copy link

ishk99 commented Nov 1, 2024

Can this issue be assigned to me ?

@ilhan007
Copy link
Member

ilhan007 commented Nov 8, 2024

Hello @ishk99, thank you for your interest, the issue requires communication with the design team and internal discussion - not just fixing what has been described, so it's not very suitable for you.

@dobrinyonkov dobrinyonkov self-assigned this Nov 8, 2024
@NakataCode
Copy link
Contributor

Hello,

I wanted to let you know that a PR addressing the issue with the subheading width has been merged. You can find it here: PR #10163.

Best regards,
Nikola

@github-project-automation github-project-automation bot moved this from Issues to Completed in Maintenance - Topic P Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio SAP SF TOPIC P
Projects
Status: Completed
Development

No branches or pull requests

8 participants