Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SF][RatingIndicator]: [Rating Star should be able to be set size and some other issues] #10155

Closed
1 task done
tandan0813 opened this issue Nov 7, 2024 · 5 comments · Fixed by #10263 or #10406
Closed
1 task done
Assignees
Milestone

Comments

@tandan0813
Copy link

Describe the bug

  1. RatingIndicator component can't set size, while UI5 version can set;
    image

  2. In a display-only form, the half rating will show a hollow star style, while the Fiori doc shows a solid one and it seems more consistant.
    React:
    image
    Doc:
    image

Isolated Example

No response

Reproduction steps

...

Expected Behaviour

No response

Screenshots or Videos

No response

UI5 Web Components for React Version

2.4.0

UI5 Web Components Version

2.4.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@tandan0813 tandan0813 added the bug This issue is a bug in the code label Nov 7, 2024
@Lukas742
Copy link
Collaborator

Lukas742 commented Nov 7, 2024

Hi @tandan0813

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

Regarding the size, please see this section of the component's description:

You can change the size of the Rating Indicator by changing its font-size CSS property.

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react Nov 7, 2024
@Todor-ads
Copy link
Member

Hello @SAP/ui5-webcomponents-topic-rl,
The mentioned issue with the half-empty star is reproducible in the playground . Could you please take a look?
Regards,
Todor

@elenastoyanovaa
Copy link
Contributor

Hello @tandan0813 ,

The first issue will be considered as a feature request. The second issue is fixed with the fix linked to this PR.

@hristop as discussed internally we need to provide a part for the icons in order for the apps to change the size of the icons.

Kind Regards,
Elena

@github-project-automation github-project-automation bot moved this from Completed to In progress in Maintenance - Topic RL Nov 29, 2024
@elenastoyanovaa elenastoyanovaa added the enhancement New feature or request label Nov 29, 2024
@hristop hristop removed the bug This issue is a bug in the code label Dec 5, 2024
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This issue has been resolved in version v2.5.0-rc.3 🎉

The release is available on v2.5.0-rc.3

Your semantic-release bot 📦🚀

@github-project-automation github-project-automation bot moved this from In Progress to Completed in Planning - Topic RL Dec 20, 2024
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This issue has been resolved in version v2.6.0-rc.3 🎉

The release is available on v2.6.0-rc.3

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment