Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SF][RatingIndicator]: The outline border will be cut when focus on the RatingIndicator #10162

Closed
1 task done
tandan0813 opened this issue Nov 8, 2024 · 2 comments · Fixed by #10205
Closed
1 task done

[SF][RatingIndicator]: The outline border will be cut when focus on the RatingIndicator #10162

tandan0813 opened this issue Nov 8, 2024 · 2 comments · Fixed by #10205
Assignees
@StefanDimitrov04
Labels
bug This issue is a bug in the code Medium Prio released TOPIC RL

Comments

@tandan0813
Copy link

Bug Description

image

When we use the RatingIndicator, the outline border will be cut when focus on the component.
image

Affected Component

RatingIndicator

Expected Behaviour

The outline is completable when focus without add extra padding.

Isolated Example

https://stackblitz.com/edit/github-7m9wj3?file=src%2FApp.tsx

Steps to Reproduce

...

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

2.4.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@tandan0813 tandan0813 added the bug This issue is a bug in the code label Nov 8, 2024
@Todor-ads
Copy link
Member

Hello @SAP/ui5-webcomponents-topic-rl,
Could you please take a look at this issue? When used independently, the component has no margin on the left and right sides. The issue can be reproduced here.
Regards,
Todor

@StefanDimitrov04 StefanDimitrov04 self-assigned this Nov 15, 2024
@StefanDimitrov04 StefanDimitrov04 mentioned this issue Nov 18, 2024
Merged
@github-project-automation github-project-automation bot moved this from In progress to Completed in Maintenance - Topic RL Dec 3, 2024
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This issue has been resolved in version v2.5.0-rc.3 🎉

The release is available on v2.5.0-rc.3

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StefanDimitrov04 StefanDimitrov04

Labels
bug This issue is a bug in the code Medium Prio released TOPIC RL
Projects
Maintenance - Topic RL
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-rating-indicator): outline border is visible when focus SAP/ui5-webcomponents
5 participants
@tandan0813 @Todor-ads @dobrinyonkov @ui5-webcomponents-bot @StefanDimitrov04