Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-form): enable vertical alignment of form items #10165

Merged
merged 7 commits into from
Nov 15, 2024
Merged

Conversation

nnaydenow
Copy link
Contributor

@nnaydenow nnaydenow commented Nov 9, 2024

This PR introduces support for two navigation flows: a simple layout with only ui5-form-item elements and a grouped layout with ui5-form-group elements.

When ui5-form is used with only ui5-form-item elements, the focus moves horizontally across each ui5-form-item, as there may be forms with custom arrangements. In this case, each ui5-form-item is treated as a separate group.

When ui5-form is used with ui5-form-group elements to create groups, the items are rendered by filling each column first, then filling the rows. In this case, the focus moves vertically through each item, column by column.

Fixes: #10032

@nnaydenow nnaydenow requested a review from ilhan007 November 9, 2024 14:54
@nnaydenow nnaydenow changed the title WIP(ui5-form): vertical alignment WIP(ui5-form): vertical alignment 2 Nov 9, 2024
packages/main/src/Form.ts Outdated Show resolved Hide resolved
@ilhan007 ilhan007 marked this pull request as ready for review November 14, 2024 12:46
@ilhan007 ilhan007 changed the title WIP(ui5-form): vertical alignment 2 feat(ui5-form): enable vertical alignment of form items Nov 14, 2024
@ilhan007 ilhan007 self-requested a review November 14, 2024 14:46
@nnaydenow nnaydenow merged commit 13b571b into main Nov 15, 2024
10 checks passed
@nnaydenow nnaydenow deleted the form-columns2 branch November 15, 2024 08:55
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.5.0-rc.1 🎉

The release is available on v2.5.0-rc.1

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Form]: should be able to render items first vertically to fill one column then fill next column
3 participants