Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SF][Table]: [Column title is not in one line when popin] #10226

Open
1 task done
tandan0813 opened this issue Nov 20, 2024 · 2 comments
Open
1 task done

[SF][Table]: [Column title is not in one line when popin] #10226

tandan0813 opened this issue Nov 20, 2024 · 2 comments
Labels
bug This issue is a bug in the code Medium Prio TOPIC TBL

Comments

@tandan0813
Copy link

tandan0813 commented Nov 20, 2024

Describe the bug

We have a requirement to display 2 lines of Column title text at most and with an icon beside it. However, when we used <Text> with maxLines props, the column title will not in one line when the table pop in. And also, if we wrapped the icon and the text with <FlexBox>, the column title won't be truncated successfully.

Isolated Example

https://stackblitz.com/edit/github-mm4cq7?file=src%2FApp.tsx,package.json

Reproduction steps

Please see the isolated example.

Expected Behaviour

The column title will display in one line when the table pop in.

Screenshots or Videos

No response

UI5 Web Components for React Version

2.4.0

UI5 Web Components Version

2.4.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@tandan0813 tandan0813 added the bug This issue is a bug in the code label Nov 20, 2024
@Lukas742
Copy link
Collaborator

Hi @tandan0813

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

And also, if we wrapped the icon and the text with , the column title won't be truncated successfully.

Setting overflow: hidden; should solve this issue: https://stackblitz.com/edit/github-mm4cq7-3j9jlo?file=src%2FApp.tsx,package.json


Hi Colleagues,
there seem to be two issues here.

1. Table behaves differently in React

When rendering Table including a header with custom content, the header is not popped in correctly when using only ui5-webcomponents, strangely it's working with React:

Table in React component

https://stackblitz.com/edit/github-mm4cq7-gthu4e?file=src%2FApp.tsx,index.html,src%2Fmain.tsx

See that the table renders the second column header both as "real" header and popped-in header. Also note that there's an error thrown:

[UI5-FWK] ui5-text not found in dependencies of ui5-table-cell

image

Table without React

https://stackblitz.com/edit/github-f5ng4m?file=index.html,main.js

See that the table renders the second column header only as "real" header and not as popped-in header. Additionally, there's no error thrown.

image

2. CSS of Popin Header container is not customizable by standard means

This is the issue described by @tandan0813. The CSS of the container (<div class="popin-header-colon" ...) of the popped in header cell is not customizable, leading to misalignments.

You can check out the React example above to see this issue: https://stackblitz.com/edit/github-mm4cq7-gthu4e?file=src%2FApp.tsx,index.html,src%2Fmain.tsx

The example isn't using our wrapper.

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react Nov 21, 2024
@ivoplashkov ivoplashkov self-assigned this Nov 21, 2024
@ivoplashkov
Copy link
Member

Hello colleagues,

The issues are reproducible and described in details by @Lukas742.
Could you please have a look?

Thank you and regards,
Ivaylo

@ivoplashkov ivoplashkov removed their assignment Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio TOPIC TBL
Projects
Status: 🆕 New
Development

No branches or pull requests

3 participants