Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-tag): correct hover background color for Set 2 Color Scheme 9 #10229

Merged
merged 4 commits into from
Nov 29, 2024
Merged

fix(ui5-tag): correct hover background color for Set 2 Color Scheme 9 #10229

merged 4 commits into from
Nov 29, 2024

Conversation

s-todorova
Copy link
Contributor

fixes: #10164

@s-todorova s-todorova requested a review from a team November 21, 2024 14:37
@s-todorova s-todorova mentioned this pull request Nov 22, 2024
Closed
LidiyaGeorgieva
LidiyaGeorgieva reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@LidiyaGeorgieva LidiyaGeorgieva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For horizon_dark maybe the parameters should be added also? Hover looks OK, but active - not.

@s-todorova s-todorova merged commit 1b2eaed into main Nov 29, 2024
10 checks passed
@s-todorova s-todorova deleted the ui5-tag-hoverColor-update branch November 29, 2024 15:57
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.5.0-rc.3 🎉

The release is available on v2.5.0-rc.3

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LidiyaGeorgieva LidiyaGeorgieva LidiyaGeorgieva approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ui5-badge & ui5-tag]: Incorrect / missing hover background color
3 participants
@s-todorova @ui5-webcomponents-bot @LidiyaGeorgieva