Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-tree): improve keydown handling in content slot #10520

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

NakataCode
Copy link
Contributor

Stop propagation of arrow down events when interacting with elements in the content slot, enabling proper functionality of interactive elements while preserving tree navigation.

Fixes: #10474

@NakataCode NakataCode marked this pull request as ready for review January 12, 2025 18:19
Copy link
Contributor

@plamenivanov91 plamenivanov91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes you wonder why it works for for UP but not for DOWN even though they pass similar call stack.

I spend some time finding the root cause but couldn't. Might be some timing issue.

I approve it as temporary solution.

@NakataCode NakataCode merged commit 1e01523 into main Jan 20, 2025
10 checks passed
@NakataCode NakataCode deleted the tree-custom-item branch January 20, 2025 08:48
@nnaydenow
Copy link
Contributor

If element inside tree item can receive focus we stop execution of keyboard handlers. Most of the times if children takes the focus it means that it's interactive element and it has its own behaviour. Check focus-within and how it is used inside different components

@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.7.0-rc.1 🎉

The release is available on v2.7.0-rc.1

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SF][Tree]: [Unable To Use Down Arrow To Change Spin Box when in Tree]
4 participants