Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-dialog): restrict max height and width based on spec #1665

Merged
merged 2 commits into from
May 22, 2020
Merged

fix(ui5-dialog): restrict max height and width based on spec #1665

merged 2 commits into from
May 22, 2020

Conversation

MapTo0
Copy link
Member

@MapTo0 MapTo0 commented May 21, 2020

FIXES: #1662

@MapTo0 MapTo0 requested a review from ilhan007 May 21, 2020 08:13
@MapTo0 MapTo0 merged commit a00225c into master May 22, 2020
@MapTo0 MapTo0 deleted the popup-scrolling branch May 22, 2020 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladitasev vladitasev vladitasev approved these changes

@ilhan007 ilhan007 Awaiting requested review from ilhan007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui5-dialog: header and footer should not scroll
2 participants
@MapTo0 @vladitasev