Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tools): Building third-party packages no longer fails #1994

Merged
merged 2 commits into from
Jul 27, 2020
Merged

fix(tools): Building third-party packages no longer fails #1994

merged 2 commits into from
Jul 27, 2020

Conversation

vladitasev
Copy link
Contributor

@vladitasev vladitasev commented Jul 27, 2020 •
edited
Loading

This change fixes 3 bugs:

  • Now the build does not try to generate JSON imports for themes that don't exist on the file system of the package (but are otherwise supported by us). Before the fix, if a third party package updated and tried to build/start, it would fail due to not having sap_fiori_3_* acc themes.
  • The init package script now also includes the new themes
  • The framework no longer requires all components to start with ui5- so this restriction has been lifted.

closes: #1970

@vladitasev vladitasev merged commit 07aebfa into master Jul 27, 2020
@vladitasev vladitasev deleted the adapt-init-package-script branch July 27, 2020 11:41
vladitasev added a commit that referenced this pull request Jul 28, 2020
@vladitasev
fix(tools): Building third-party packages no longer fails (#1994)
afdd506
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

@MapTo0 MapTo0 Awaiting requested review from MapTo0

@fifoosid fifoosid Awaiting requested review from fifoosid

Assignees
No one assigned
Labels
for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

After adding the 2 new themes, building third-party packages fails
2 participants
@vladitasev @ilhan007