Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[All] Dropping a file outside upload collection removes page scrollbar #2001

Closed
vladitasev opened this issue Jul 27, 2020 · 2 comments · Fixed by #2527
Closed

[All] Dropping a file outside upload collection removes page scrollbar #2001

vladitasev opened this issue Jul 27, 2020 · 2 comments · Fixed by #2527

Comments

@vladitasev
Copy link
Contributor

http://localhost:8081/test-resources/pages/UploadCollection.html

Initially:
image

Drop some file between upload collections:

image

Scrollbar is gone

@georgimkv
Copy link
Contributor

Hi Vladi,

That's the expected behaviour. Initially the UploadCollection is empty, for which a min-height is applied to it:

.ui5-uc-content.ui5-uc-content-no-data {
    min-height: 20rem;
}

Once there are elements in the default slot (files were uploaded), that ui5-uc-content-no-data class is removed and the element is as tall as its contained children, which in this case is shorter than the inital height of 20rem, causing the page to shrink in height, therefore removing its scrollbar.

@georgimkv georgimkv reopened this Nov 30, 2020
@georgimkv
Copy link
Contributor

The component accepts dropping files in its header area which should be changed. It should only allow dropping in its 'drop-zone'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants