feat(ui5-panel): make the header clickable #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
requested review from
pskelin and
vladitasev
and removed request for
pskelin
vladitasev
reviewed
Mar 19, 2019
|
ilhan007
changed the title
pskelin
previously approved these changes
Mar 19, 2019
There was a problem hiding this comment.
this proposal matches the behaviour of the details HTMLElement so we should strive for the same by default
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/details
pskelin
previously requested changes
Mar 19, 2019
packages/main/src/Panel.js
Outdated
|
|
||
| _getHeader() { | ||
| return this.shadowRoot.querySelector(".sapMPanelWrappingDiv"); | ||
| debugger; |
There was a problem hiding this comment.
it is removed with the last commit
pskelin
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the entire header area clickable in order to toggle the panel, add keyboard handling (SPACE and ENTER) and focus outline. Note, that this would be the default behaviour. If custom header is set, only the icon will be clickable out of the box (as currently).
Fixes: #194