Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-calendar-header): prevent scrolling when month/year picker is selected #2276

Merged
merged 1 commit into from
Oct 1, 2020
Merged

fix(ui5-calendar-header): prevent scrolling when month/year picker is selected #2276

merged 1 commit into from
Oct 1, 2020

Conversation

fifoosid
Copy link
Contributor

@fifoosid fifoosid commented Sep 30, 2020 •
edited by ilhan007
Loading

Part of #2268

@ilhan007 ilhan007 mentioned this pull request Sep 30, 2020
Merged
@fifoosid fifoosid merged commit fac40a8 into master Oct 1, 2020
@fifoosid fifoosid deleted the ch-keydown branch October 1, 2020 07:08
ilhan007 added a commit that referenced this pull request Oct 1, 2020
@ilhan007
fix(ui5-date-picker): select date with SPACE on keyup (#2279)
9d83806 
This PR complements the following PR #2276
to fix everything requested by the referenced issue, more specifically forcing date selection with SPACE to take place on keyup, instead of keydown as at the moment.

FIXES: #2268
ilhan007 pushed a commit that referenced this pull request Oct 17, 2020
@fifoosid @ilhan007
fix(ui5-calendar-header): prevent scrolling when month/year picker is…
a33e69b 
… selected (#2276)
ilhan007 added a commit that referenced this pull request Oct 17, 2020
@ilhan007
fix(ui5-date-picker): select date with SPACE on keyup (#2279)
fea76b2 
This PR complements the following PR #2276
to fix everything requested by the referenced issue, more specifically forcing date selection with SPACE to take place on keyup, instead of keydown as at the moment.

FIXES: #2268
ilhan007 pushed a commit that referenced this pull request Nov 11, 2020
@fifoosid @ilhan007
fix(ui5-calendar-header): prevent scrolling when month/year picker is…
900c70d 
… selected (#2276)
ilhan007 added a commit that referenced this pull request Nov 11, 2020
@ilhan007
fix(ui5-date-picker): select date with SPACE on keyup (#2279)
3f285b5 
This PR complements the following PR #2276
to fix everything requested by the referenced issue, more specifically forcing date selection with SPACE to take place on keyup, instead of keydown as at the moment.

FIXES: #2268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

Assignees
No one assigned
Labels
for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fifoosid @ilhan007