Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(framework): Allow role as a property name #2290

Merged
merged 2 commits into from
Oct 5, 2020
Merged

Conversation

vladitasev
Copy link
Contributor

Allow role as a property name for UI5 Web Components.

Additionally, allow developers to override any property, but produce a warning except for the allowed.

ilhan007
ilhan007 previously approved these changes Oct 2, 2020
fifoosid
fifoosid previously approved these changes Oct 2, 2020
@vladitasev vladitasev dismissed stale reviews from fifoosid and ilhan007 via 2b2c23b October 5, 2020 06:16
@vladitasev vladitasev merged commit a816cef into master Oct 5, 2020
@vladitasev vladitasev deleted the allow-role-as-name branch October 5, 2020 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants