feat(ui5-link): add aria-label and aria-labelledby support #2357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elenastoyanovaa could you see this change, we forward aria-label and aria-labelledby from the ui5-ilink to the internal "a" tag as "aria-label". The thing is that voiceOver reads it twice. |
elenastoyanovaa
approved these changes
Oct 23, 2020
ilhan007
added a commit
that referenced
this pull request
Nov 2, 2020
ilhan007
added a commit
that referenced
this pull request
Nov 11, 2020
ilhan007
added a commit
that referenced
this pull request
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES: #2356
Side effect: On VoiceOver the aria-label is read twice.