fix(ui5-textarea): announce required textarea #2385
Conversation
packages/main/src/TextArea.hbs
Outdated
| @@ -25,6 +28,7 @@ | |||
| ?required="{{required}}" | |||
| aria-required="{{required}}" | |||
| aria-label="{{ariaLabelText}}" | |||
| aria-labelledby="{{_id}}-acc-text" | |||
There was a problem hiding this comment.
not sure if by adding aria-labelledby would prevent aria-label from reading, can you sync that with an expert, if not already discussed of course
There was a problem hiding this comment.
This is not a problem. The aria-label attribute is still read out by the screen reader
There was a problem hiding this comment.
This is not the way to go with ACC related issues. If a certain information is not read out, even though it is set correctly, you should find the root cause (usually a SR software + browser issue). This is a workaround and I would prefer to not submit this kind of fixes - if the issue is indeed specific to the testing environment this would result in a double speech output in other browser+SR testing combinations and also when the issue is resolved in future.
What is more the reporter is right that when we have a native required attribute, the aria-required is not needed and should be removed (also it is not in the spec, I am not sure why it is there at all).
If the issue still persists, after removing the aria-required the problem should be isolated in a native example and tested if indeed the issue is not UI5 web components related.
Could you do the things above and also remove the aria-labelledby workaround and if the issue persists, isolate and test with native HTML and come back to me?
Part of #2374