Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-popover): implement hide-block-layer property #2413

Merged
merged 5 commits into from
Nov 19, 2020
Merged

feat(ui5-popover): implement hide-block-layer property #2413

merged 5 commits into from
Nov 19, 2020

Conversation

fifoosid
Copy link
Contributor

Fixes #2406

ilhan007
ilhan007 requested changes Oct 28, 2020
View reviewed changes
Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's worth adding a test, moreover soon the components will be handed over and it is good if they have decent code coverage

packages/main/src/Popover.js Outdated Show resolved Hide resolved
vladitasev
vladitasev previously requested changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename "block layer" to "backdrop" only in the public API as this is what most people would understand. The hide/showBlockLayer functions are already used in third-party popups so don't rename them

@fifoosid fifoosid requested a review from vladitasev November 11, 2020 09:08
@ilhan007
Copy link
Member

It is fine to m, @vladitasev could you check if everything is ok, I removed your review as outdated

@fifoosid fifoosid merged commit 3b2d6de into master Nov 19, 2020
@fifoosid fifoosid deleted the popover-hide-block-layer branch November 19, 2020 08:15
ilhan007 pushed a commit that referenced this pull request Nov 19, 2020
@fifoosid @ilhan007
feat(ui5-popover): implement hide-block-layer property (#2413)
5c3672e
fifoosid added a commit that referenced this pull request Dec 10, 2020
@fifoosid
feat(ui5-popover): implement hide-block-layer property (#2413)
67d3d8f
fifoosid added a commit that referenced this pull request Dec 15, 2020
@fifoosid
feat(ui5-popover): implement hide-block-layer property (#2413)
5bf8523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

@vladitasev vladitasev Awaiting requested review from vladitasev

Assignees
No one assigned
Labels
SAP SF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request][Popover] Mask can be turned on or off when modal is enabled
4 participants
@fifoosid @ilhan007 @vladitasev @petyabegovska