feat(ui5-calendar): introduce new component. #2424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Lint errors fixed
…into calnedar-stand-alone
ilhan007
requested changes
Nov 2, 2020
…into calnedar-stand-alone
- "CalendarSelection" enum class is introduced with single, multiple and range selection modes. - DayPicker component uses the new "CalendarSelection" class, in order to provide support for the three selection modes. - Selection of multiple dates can be configured via the "selection" property of the Calendar component. Holding control keyboard key doesn't allow multiple dates selection. - The logic for selecting a range of dates is moved from the DateRangePicker component into the DayPicker component. - Selecting a range of dates via mouse now doesn't cause flickering on the hovered items. - Updating the selected date range into the DateRangePicker component input field is now reflected visually, when the popover is opened.
|
|
- Lint erros fixed
…into calnedar-stand-alone
- Calendar tests are added.
unazko
requested review from
tsanislavgatev,
fifoosid,
NHristov-sap and
ilhan007
NHristov-sap
previously requested changes
Nov 16, 2020
component "selection" property. - Typos fixed.
…into calnedar-stand-alone
The "selection" property value could be changed. There is currently no getter implemented. |
A new range can be selected if there is already a selected range. The selected range from the input field is now applied to the Calendar component only when the popover is opened.
in the on before rendering hook. When a new range is being selected by user interaction the input field is getting cleared.
BorisDafov
reviewed
Nov 18, 2020
ilhan007
reviewed
Nov 24, 2020
ilhan007
reviewed
Nov 24, 2020
…into calnedar-stand-alone
in order to change the current item navigation tab index. - The tab index of the calendar header buttons is changed through the calendar header template.
|
There are failing tests in relation to the ui5-calendar component after merging the conflicts. Adjustments are needed. |
- ui5-calendar tests adjusted - When "Range" or "Multiple" type of selection is configured, then the last selected date by user interaction is also the navigated date. - ui5-daterange-picker now works properly with only the start date of the range typed into the input field.
- Lint erros fixed.
ilhan007
reviewed
Nov 26, 2020
ilhan007
reviewed
Nov 26, 2020
ilhan007
reviewed
Nov 26, 2020
ilhan007
reviewed
Nov 26, 2020
ilhan007
reviewed
Nov 26, 2020
ilhan007
reviewed
Nov 26, 2020
- playground sample since tag is added - playground sample visualization is adjusted
ilhan007
changed the title
ilhan007
reviewed
Nov 27, 2020
ilhan007
reviewed
Nov 27, 2020
ilhan007
requested changes
Nov 27, 2020
There was a problem hiding this comment.
- add test about the selection in combination with the event firing
- mark the Calendar as new for the playground by adding it in this array
// Add new components here
// packages/playground/build-scripts/samples-prepare.js
const newComponents = [
"MultiInput",
"RangeSlider",
"Slider",
"Wizard",
];is now added in the component metadata. - ui5-calendar selection types are now tested. - ui5-calendar component is marked as new in the playground.
Tests are added and the component is added as new for the playground. Done. |
ilhan007
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(ui5-calendar): component is now public and can be used standalone.
range selection modes.
in order to provide support for the three selection modes.
property of the Calendar component. Holding control keyboard key doesn't
allow multiple dates selection.
the DateRangePicker component into the DayPicker component.
on the hovered items.
input field is now reflected visually, when the popover is opened.
typed into the input field.
Fixes #1730