refactor(icons): flatten dist directory #2425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladitasev
approved these changes
Nov 2, 2020
ilhan007
added a commit
that referenced
this pull request
Nov 11, 2020
Change the distribution path of all individual `icons`, which changes all icons' public imports, by bringing the icons modules one level up and removing the additional "icons" folder: ```js import "@ui5/webcomponents-icons/dist/accept.js"; ``` BREAKING_CHANGE: All icons imports are changed. The individual icons modules are available in the icon package's "dist" folder. If you previously had `import "@ui5/webcomponents-icons/dist/icons/accept.js"`, now it becomes `import "@ui5/webcomponents-icons/dist/accept.js";`
ilhan007
added a commit
that referenced
this pull request
Nov 19, 2020
Change the distribution path of all individual `icons`, which changes all icons' public imports, by bringing the icons modules one level up and removing the additional "icons" folder: ```js import "@ui5/webcomponents-icons/dist/accept.js"; ``` BREAKING_CHANGE: All icons imports are changed. The individual icons modules are available in the icon package's "dist" folder. If you previously had `import "@ui5/webcomponents-icons/dist/icons/accept.js"`, now it becomes `import "@ui5/webcomponents-icons/dist/accept.js";`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the distribution path of all individual
icons, which changes all icons' public imports, by bringing the icons modules one level up and removing the additionaldist/iconsfolder.And remove the assumption for multiple collections in the
iconspackage by removing theicon-collectionsfolder and moving theSAP-icons.jsonfile:icons/src/icon-collections/SAP-icons.json→packages/icons/src/SAP-icons.json.Add options to the build config script to be used by the upcoming new
icons-tnt, while theicons` can use the default config.Old:
New:
BREAKING_CHANGE: All icons imports are changed. The individual icons modules are available in the icon package's "dist" folder. If you previously had
import "@ui5/webcomponents-icons/dist/icons/accept.js", now it becomesimport "@ui5/webcomponents-icons/dist/accept.js";