Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-combobox): User action cancelled when clicking "X" on mobile #2742

Merged
merged 3 commits into from
Feb 12, 2021
Merged

fix(ui5-combobox): User action cancelled when clicking "X" on mobile #2742

merged 3 commits into from
Feb 12, 2021

Conversation

Martotko
Copy link
Contributor

Fixes: #2449

@Martotko Martotko requested review from MapTo0 and ilhan007 January 28, 2021 11:33
MapTo0
MapTo0 requested changes Feb 1, 2021
View reviewed changes
Copy link
Member

@MapTo0 MapTo0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_selectedItem sounds a little bit strange. Maybe _selectedItemText / TItle ??

  • add tests

@Martotko
Copy link
Contributor Author

Martotko commented Feb 2, 2021

_selectedItem sounds a little bit strange. Maybe _selectedItemText / TItle ??

  • add tests

Variable is updated. About the test, I wasn't able to simulate a mobile device so as to test it, furthermore, there don't have any tests for mobile devices.

@Martotko Martotko requested a review from MapTo0 February 2, 2021 13:41
MapTo0
MapTo0 previously approved these changes Feb 11, 2021
View reviewed changes
ilhan007
ilhan007 requested changes Feb 11, 2021
View reviewed changes
Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix, just hold for a while until I check it please

@Martotko Martotko requested a review from ilhan007 February 11, 2021 09:48
ilhan007
ilhan007 requested changes Feb 11, 2021
View reviewed changes
Copy link
Member

@ilhan007 ilhan007 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not seem to work as expected

Here you can see openui5 cbx with selected "Bulgaria", open the picker, you can see "Bulgaria", clicking "X" - you see Bulgaria

openui5.mov

The Current change: "Bulgaria' is selected, open the picker - "Bulgaria" is already lost, close the picker with X, "Bulgaria" is lost:

ui5wc.mov

@Martotko Martotko requested review from ilhan007 and MapTo0 February 12, 2021 13:11
@ilhan007 ilhan007 merged commit 691c2e4 into SAP:master Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

@MapTo0 MapTo0 Awaiting requested review from MapTo0

Assignees
No one assigned
Labels
for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui5-combobox: clicking "X" on mobile doesn't cancel selection
3 participants
@Martotko @MapTo0 @ilhan007