fix(ui5-li-notification): It is now possible to not have a description #2744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
approved these changes
Jan 28, 2021
alexandar-mitsev
pushed a commit
to alexandar-mitsev/ui5-webcomponents
that referenced
this pull request
Feb 1, 2021
NHristov-sap
pushed a commit
to NHristov-sap/ui5-webcomponents
that referenced
this pull request
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
descriptionis the default slot of typeNode, there are usually at least some whitespaces such as new lines that go into that slot, so it is never empty, unless in the following marginal use case:Then the component used to fail since there is no description DOM.