feat(ui5-input): introduce new SuggestionGroupItem #3248
Merged
+112
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a dedicated component SuggestionGroupItem to split the suggestions into groups. Previously the app developers had to use the standard SuggestionItem and set its "group" property. But, as the group item do not have most of the interactive features, we decided to introduce dedicated component for the purpose. Related to: #3107
BREAKING_CHANGE: The "group" property of the SuggestionItem is removed, use the SuggestionGroupItem component to create grouping as follows: