Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slotting in image in a card makes it round #3299

Closed
vladitasev opened this issue May 21, 2021 · 0 comments · Fixed by #3301
Closed

Slotting in image in a card makes it round #3299

vladitasev opened this issue May 21, 2021 · 0 comments · Fixed by #3301
Assignees
@fifoosid
Labels
bug This issue is a bug in the code High Prio TOPIC RD

Comments

@vladitasev
Copy link
Contributor

ui5-card has

::slotted(img) {
}

in the CSS, which is intended for the avatar slot. However, I want the image to be the content of the card (default slot) so I don't want it to be modified. Please add a slot attribute for the ::slotted CSS selector to restrict this to the avatar slot only
@ilhan007 ilhan007 changed the title Slogging in image in a card makes it round Slotting in image in a card makes it round May 21, 2021
@fifoosid fifoosid self-assigned this May 21, 2021
@fifoosid fifoosid mentioned this issue May 21, 2021
Merged
@ilhan007 ilhan007 added bug This issue is a bug in the code TOPIC RD labels May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fifoosid fifoosid

Labels
bug This issue is a bug in the code High Prio TOPIC RD
Projects
Maintenance - Topic RD
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-card): fix styles for slotted images SAP/ui5-webcomponents
3 participants
@ilhan007 @vladitasev @fifoosid